refactor: match span id earlier #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
added a commit
to Rustin170506/console
that referenced
this pull request
Apr 6, 2024
Follow the same pattern applied in tokio-rs#533 to match the span id earlier to avoid checking twice.
Rustin170506
added a commit
to Rustin170506/console
that referenced
this pull request
Apr 6, 2024
Follow the same pattern applied in tokio-rs#533 to match the span id earlier to avoid checking twice.
Rustin170506
added a commit
that referenced
this pull request
Apr 6, 2024
Follow the same pattern applied in #533 to match the span id earlier to avoid checking twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple refactoring to match and get span ID first. Then we don't need to check it twice.
Also, align logs to use
id.